Merged
Conversation
hadley
reviewed
Oct 10, 2019
Member
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).
tests/testthat/test-word.r
Outdated
| }) | ||
|
|
||
| test_that("negative parameters", { | ||
| expect_equal("moon",word("walk the moon", -1, -1)) |
Member
There was a problem hiding this comment.
Can you please add the missing space before word()?
Also you only need the first line here as the other two test the same code path.
Contributor
Author
There was a problem hiding this comment.
Done!
Although I will suggest to keep the other two lines since they test a specific behavior: return all the sentence if the negative start parameter is greater than the number of words. Important to have a consistent API with str_sub.
Let me know if you want to remove it anyways!
Contributor
Author
|
Made all the changes. Let me know if anything else is needed! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing unconsistent behavior described in #245 and adding some test.