add exportClass(tbl_df) to NAMESPACE #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I forgot to document the S4 class so now the checks are failing. I'll sort this out in a minute. |
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 25 25
Lines 1048 1048
=======================================
Hits 952 952
Misses 96 96
Continue to review full report at Codecov.
|
|
Thanks! I keep forgetting updating the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds roxygen2 commands to add
exportClass(tbl_df)to the _NAMESPACE (see tbl_df.r) and an updated NAMESPACE file. Since I randevtools::document()to update the package's NAMESPACE, it appears that several other files got updated in the process. I figured you might want to have these files in synch with the roxygen2 code - but let me know if I should resubmit this PR with just the tbl_df.r and NAMESPACE files updated. For more information on this PR, please see #434.