Very slow subsetting for character

[krlmlr]

tidyverse/ggplot2#3018 (comment).

[yutannihilation]

Here's a quick profile of [.tbl_df on my laptop. It seems safe_match() in check_names_df.character() is the main cause of slow subsetting for character. So, I think you can fix this somehow.

But, as these checks seem basically necessary, I guess [.tbl_df will stay several times slower than [.data.frame for a while. Can I expect [.tbl_df will get as fast as [.data.frame in future? (or in version 2.0.0?)

Codes:

library(tibble)

d <- data.frame(a = 1, b = 2, c = 3)
t <- as_tibble(d)

profvis::profvis({for (i in 1:1e5) {t[, "c"]}})
profvis::profvis({for (i in 1:1e5) {t[, 3]}})

Results:

[krlmlr]

Thanks. That's the same profile I see. I think we might be able to make it ~8x faster if necessary, not sure if that's fast enough.

[yutannihilation]

Yeah, the problem is we don't know how fast is fast enough... but ~8x faster sounds great.

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.