Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export dim_desc() #55

Merged
merged 1 commit into from
Mar 21, 2016
Merged

Don't export dim_desc() #55

merged 1 commit into from
Mar 21, 2016

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 21, 2016

to be on the safe side for the CRAN release.

Fixes #50.

@codecov-io
Copy link

Current coverage is 100.00%

Merging #55 into master will not affect coverage as of fefae22

@@            master     #55   diff @@
======================================
  Files           14      14       
  Stmts          437     437       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            437     437       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of fefae22

Powered by Codecov. Updated on successful CI builds.

@krlmlr krlmlr mentioned this pull request Mar 21, 2016
krlmlr added a commit that referenced this pull request Mar 21, 2016
@krlmlr krlmlr merged commit dcdd828 into master Mar 21, 2016
@krlmlr krlmlr deleted the feature/50-remove-dim_desc branch March 21, 2016 18:50
krlmlr pushed a commit that referenced this pull request Mar 21, 2016
- `glimpse()` obtains default width from `tibble.width` option (#35, #56).
- Don't export `dim_desc()` (#50, #55).
- Don't test R-devel on AppVeyor because of missing directory on CRAN.
- Edits to `README` (#54, @jennybc).
krlmlr pushed a commit that referenced this pull request Mar 21, 2016
- Interface changes
    - `glimpse()` obtains default width from `tibble.width` option (#35, #56).
    - Don't export `dim_desc()` (#50, #55).
    - New `has_rownames()` and `remove_rownames()` (#44).
- Minor modifications
    - `frame_data()` returns 0-row but n-col data frame if no data.
    - `[[.tbl_df()` now falls back to regular subsetting when used with anything other than a single string (#29).
    - When used in list-columns, S4 objects only print the class name rather than the full class hierarchy (#33).
    - Add test that `[.tbl_df()` does not change class (#41, @jennybc).
    - Improve `[.tbl_df()` error message.
- Documentation
    - Improve documentation and vignette.
    - Update README, with edits (#52, @bhive01) and enhancements (#54, @jennybc).
- Code quality
    - Full test coverage (#24, #53).
    - Renamed `obj_type()` to `obj_sum()`, improvements, better integration with `type_sum()`.
    - Cleanup for `column_to_rownames()` and `rownames_to_columns()` (#45).
    - Cleanup for `repair_names()` (#43). Whitespace are not touched by this function (#47).
    - Cleanup for `add_row()` (#46).
    - Regression tests load known output from file (#49).
    - Internal cleanup.
    - Don't test R-devel on AppVeyor because of missing directory on CRAN.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink exporting dim_desc()
2 participants