Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use as_data_frame from dplyr #131

Closed
hadley opened this issue Oct 29, 2015 · 3 comments
Closed

Use as_data_frame from dplyr #131

hadley opened this issue Oct 29, 2015 · 3 comments

Comments

@hadley
Copy link
Member

hadley commented Oct 29, 2015

instead of matrixToDataframe
@krlmlr krlmlr mentioned this issue Oct 31, 2015
Closed
@hadley
Copy link
Member Author

hadley commented Dec 30, 2015

A simple replacement doesn't work because we want to force coercion from a matrix, and a matrix of dates doesn't have (explicit) class "Date".

@hadley
Copy link
Member Author

hadley commented Dec 30, 2015

Also need to copy across unit tests

@hadley hadley closed this as completed in ad9e003 Dec 30, 2015
@hadley
Copy link
Member Author

hadley commented Dec 30, 2015

Need to wait until 0.5 comes out: then use utils::getS3method("as_data_frame", "matrix")(ordered)

@hadley hadley reopened this Dec 30, 2015
hadley added a commit that referenced this issue Dec 30, 2015
@hadley
Oops as_data_frame is in dev dplyr. #131
b622b34
@krlmlr krlmlr mentioned this issue Mar 2, 2016
Closed
6 tasks
This was referenced May 17, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hadley