Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording in import section of packages #77

Closed
mine-cetinkaya-rundel opened this issue Jan 3, 2018 · 7 comments · Fixed by #421
Closed

Wording in import section of packages #77

mine-cetinkaya-rundel opened this issue Jan 3, 2018 · 7 comments · Fixed by #421

Comments

@mine-cetinkaya-rundel
Copy link
Member

Currently it says "There are a handful of other packages that are not in the tidyverse, but are tidyverse-adjacent. They are very useful for importing data from other sources:" and lists jsonlite, xml2, httr, rvest, and DBI under this. It's unclear to me what the difference of these from readxl and haven is since all of these packages are installed with tidyverse but are not in the core. It might be more clear to list all in the same hierarchy (as is the case in the tidyverse repo README).

@batpigandme
Copy link
Collaborator

batpigandme commented Jan 18, 2018

Just getting back to this now, @mine-cetinkaya-rundel! The distinction that I can see is that they're not tidyverse repos: httr and xml2 are in r-lib, jsonlite is Jeroen's, rvest is still a hadley repo, and DBI isn't on the tidyverse repo list to which I believe you're referring.

None of the above is to say that it's clear to anyone reading the site; but, given they also don't have tidyverse pages (package.tidyverse.org), I can imagine it being slightly confusing not to differentiate at all. That said, I'm not opposed to changing it as you've described at all. Just kind of digging around to figure things out.

@hadley
Copy link
Member

hadley commented Jan 18, 2018

Yeah, maybe we should move all those packages into an affiliates section? Or friends maybe? They're installed with the tidyverse package, but they're not members of the tidyverse organisation. Or is that another layer that's just too confusing?

@batpigandme
Copy link
Collaborator

Oh, interesting. I didn't realise that blob, hms, modelr, and broom didn't have associated pages, so at least one part of my reasoning has crumbled.

@mine-cetinkaya-rundel
Copy link
Member Author

I think with a brief definition of the layers on top of the page, another layer wouldn't necessarily make things more confusing.

@hadley

This comment has been minimized.

@batpigandme

This comment has been minimized.

@hadley

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants