Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default message should use rows and cols #140

Closed
hadley opened this issue Jun 23, 2019 · 1 comment
Closed

Default message should use rows and cols #140

hadley opened this issue Jun 23, 2019 · 1 comment
Labels
good first issue ❤️ good issue for first-time contributors tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@hadley
Copy link
Member

hadley commented Jun 23, 2019

logs <- vroom::vroom("cran-logs/2019-02-20.csv.gz", delim = ",")
#> Observations: 3,437,899                                                                            
#> Variables: 10

Should be:

logs <- vroom::vroom("cran-logs/2019-02-20.csv.gz", delim = ",")
#> Rows: 3,437,899                                                                            
#> Cols: 10

Because we have no idea whether the data is tidy or not

@jimhester
Copy link
Collaborator

I used Observations and Variables to match dplyr::glimpse(), the same is true there as well right?

But I am happy to change it, Rows and Cols are easier for me to interpret anyway.

@jimhester jimhester added good first issue ❤️ good issue for first-time contributors tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day labels Jun 24, 2019
meta00 added a commit to meta00/vroom that referenced this issue Jul 8, 2019
meta00 added a commit to meta00/vroom that referenced this issue Jul 8, 2019
meta00 added a commit to meta00/vroom that referenced this issue Jul 8, 2019
@hadley hadley closed this as completed in 843e4a6 Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue ❤️ good issue for first-time contributors tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

No branches or pull requests

2 participants