Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use control_cmd_auto instead #152

Closed
wants to merge 1 commit into from

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jun 20, 2023

Link to the issue

Part of: autowarefoundation/autoware.universe#3674

Description

Using this,

Autoware will publish:

Topic Message Type
/control/command/control_cmd autoware_msgs
/control/command/control_cmd_auto autoware_auto_msgs

To enable compatibility, this PR renames the incoming topic to suffix _auto.

How to review this PR

Others

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@shmpwk
Copy link
Contributor

shmpwk commented Jul 10, 2023

@xmfcx
Should we change this also?

ISubscription<autoware_auto_control_msgs.msg.AckermannControlCommand> ackermanControlCommandSubscriber;

- ISubscription<autoware_auto_control_msgs.msg.AckermannControlCommand> ackermanControlCommandSubscriber;
+ ISubscription<autoware_control_msgs.msg.Control> ackermanControlCommandSubscriber;

@shmpwk
Copy link
Contributor

shmpwk commented Jul 10, 2023

This PR can be merged after correspondent Autoware stable version is updated.

@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 10, 2023

@shmpwk

Autoware will publish both of the following messages:

Topic Message Type
/control/command/control_cmd autoware_msgs
/control/command/control_cmd_auto autoware_auto_msgs

So we should either use the new type, or the old one.

Current PR makes it use the old message type.

If you want, I can make it use the new message type.

@shmpwk
Copy link
Contributor

shmpwk commented Jul 10, 2023

@xmfcx
Got it, thank you. The current PR seems sufficient.

@xmfcx xmfcx marked this pull request as draft December 20, 2023 08:04
@xmfcx
Copy link
Contributor Author

xmfcx commented Mar 7, 2024

I'm closing all of my message migration PRs.

@xmfcx xmfcx closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants