fix(ndt): fix build error in Humble #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-ohta
requested review from
m-iwashita-esol,
v-nojiri7841-esol and
v-sugahara7993-esol
m-iwashita-esol
approved these changes
May 15, 2023
There was a problem hiding this comment.
autowarefoundation#793
の下記ソース変更が正しく取り込まれている事を確認しました
localization/ndt/CMakeLists.txt
localization/ndt/include/ndt/base.hpp
localization/ndt/include/ndt/impl/omp.hpp
localization/ndt/include/ndt/impl/pcl_generic.hpp
localization/ndt/include/ndt/impl/pcl_modified.hpp
localization/ndt/include/ndt/omp.hpp
localization/ndt/include/ndt/pcl_generic.hpp
localization/ndt/include/ndt/pcl_modified.hpp
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
autowarefoundation#793 を参考にビルドエラーを修正
#445 で依存パッケージのndt_pcl_modifiedの修正も実施しているため、先にこちらをマージする必要あり
Related Links
https://tier4.atlassian.net/browse/AEAP-488
Tests performed
参考元と同じ変更になっていること
ndtがビルドできること
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.