feat: ignore rcl_timer_init() from ros2 launch command #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyakoshi-dev
changed the title
miyakoshi-dev
changed the title
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
===========================================
+ Coverage 26.23% 39.77% +13.53%
===========================================
Files 58 28 -30
Lines 3106 1878 -1228
Branches 978 981 +3
===========================================
- Hits 815 747 -68
+ Misses 1574 407 -1167
- Partials 717 724 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
isp-uetsuki
requested changes
Jun 29, 2023
isp-uetsuki
requested changes
Jul 3, 2023
takeshi-iwanari
suggested changes
Jul 4, 2023
isp-uetsuki
requested changes
Jul 14, 2023
takeshi-iwanari
suggested changes
Jul 18, 2023
There was a problem hiding this comment.
- I confirmed this PR fixes the original issue
- Please consider to fix the followings
- comments in the code as I reviewed
- description of this PR
- this change is not only for "ros2 launch" but for any "python3" command
- add explanation WHY rcl_timer_init() from python3 command needs to be ignored
miyakoshi-dev
dismissed stale reviews from nabetetsu and isp-uetsuki
via
6e68504
takeshi-iwanari
approved these changes
Jul 20, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the processes started with python3 had a process that issued rcl_timer_init() not associated with a node in a short cycle.
As a result, the information acquired by CARET_trace increases with the passage of time, and a phenomenon occurs in which it takes time to complete measurement.
For this reason, restrict rcl_timer_init() to be excluded when invoked by the python3 command.
(memo)Currently, measurement via python3 (rclpy) is not supported.
Related links
https://tier4.atlassian.net/browse/RT2-591
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.