feat(people-names/words): add VRichard #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tier4-autoware-public-bot[bot]](https://avatars.githubusercontent.com/in/168304?s=60&v=4){kind=small}
Signed-off-by: GitHub <noreply@github.com>
tier4-autoware-public-bot
bot
requested a review
from kenji-miyake
as a code owner
|
@kenji-miyake I updated the pull-request description. |
|
@HansRobo How about using |
|
OK, I'll fix it. |
HansRobo
changed the title
kenji-miyake
suggested changes
May 19, 2023
| @@ -6,3 +6,4 @@ Koide | |||
| Menegatti | |||
| Miura | |||
| Miyake | |||
| VRichard | |||
There was a problem hiding this comment.
Sorry, I meant you should fix here instead of adding the word.
https://github.com/autowarefoundation/autoware.universe/blob/main/planning/behavior_velocity_planner/src/node.cpp#L324
There was a problem hiding this comment.
Oh, I see.
I will fix in the source comment and check if fails cspell after fix it.
There was a problem hiding this comment.
@kenji-miyake The error is fixed after modifying source comment.
So, I close this pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vrichard, a name of autoware contributor
refs: