Configure resource requests and limits #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@vara2504 You've partially reorganized the PR, but there's still a few things left.
Once that's sorted, I'll get to the line edits. Thanks! |
|
@ctauchen My bad. I missed to add the untracked files. It should be good now. |
ctauchen
reviewed
Mar 28, 2024
Comment on lines
14
to
15
|
|
||
|
|
| ``` | ||
| This command sets the CPU request to 100 milliCPU (mCPU) and the memory request is set to 100 Mebibytes (MiB) while the CPU limit is set to 1 CPU and the memory limit is set to 1000 Mebibytes (MiB). | ||
|
|
||
| Verifying Resources: |
There was a problem hiding this comment.
Suggested change
| Verifying Resources: | |
| #### Verification |
Change globally.
|
|
||
|
|
||
|
|
||
| ## APIServer |
There was a problem hiding this comment.
Suggested change
| ## APIServer | |
| ## APIServer custom resource |
Change globally for CRs. Helps visually to distinguish the major buckets from smaller types.
Comment on lines
72
to
74
| The [ApplicationLayer](../../reference/installation/api.mdx#operator.tigera.io/v1.ApplicationLayer) CR provides a way to configure resources for L7LogCollectorDaemonSet. | ||
|
|
||
| Example Configurations: |
There was a problem hiding this comment.
Suggested change
| The [ApplicationLayer](../../reference/installation/api.mdx#operator.tigera.io/v1.ApplicationLayer) CR provides a way to configure resources for L7LogCollectorDaemonSet. | |
| Example Configurations: | |
| The [ApplicationLayer](../../reference/installation/api.mdx#operator.tigera.io/v1.ApplicationLayer) CR provides a way to configure resources for L7LogCollectorDaemonSet. The following sections provide example configurations for this CR. |
Change globally.
Comment on lines
1127
to
1128
|
|
||
| ### ############################ |
|
@ctauchen Addressed the review commands. Please take a look and let me know. |
|
LGTM, thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tigera.atlassian.net/browse/EV-4687
Product Version(s):
Issue:
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: