Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS configure resource request changes #1409

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Conversation

vara2504
Copy link
Contributor

@vara2504 vara2504 commented Apr 4, 2024

Add csi-node-driver spec
enterprise doc:
#1379

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@vara2504 vara2504 requested a review from a team as a code owner April 4, 2024 23:52
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 2240eb1
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/66149be1298f7900086b90c0
😎 Deploy Preview https://deploy-preview-1409--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 43 (🔴 down 20 from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2240eb1
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/66149be13f66f5000821cf59
😎 Deploy Preview https://deploy-preview-1409--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 51 (🟢 up 10 from production)
Accessibility: 91 (no change from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@vara2504
Copy link
Contributor Author

vara2504 commented Apr 4, 2024

@ctauchen I have created a similar doc for OSS. And add a component that was missed previous in EE.
Will create another PR for cloud once get the list of components applicable for calico cloud team.

@ctauchen
Copy link
Collaborator

ctauchen commented Apr 5, 2024

Just want to confirm this is intended for OSS 3.28?

@vara2504
Copy link
Contributor Author

vara2504 commented Apr 5, 2024

@ctauchen yes it is OSS 3.28 . I have updated the doc for calico cloud too. i could not test the changes because i see next drop down (when i do yarn start-next) only for enterprise and OSS not for cloud. Am i missing some thing?

@ctauchen
Copy link
Collaborator

ctauchen commented Apr 8, 2024

@ctauchen yes it is OSS 3.28 . I have updated the doc for calico cloud too. i could not test the changes because i see next drop down (when i do yarn start-next) only for enterprise and OSS not for cloud. Am i missing some thing?

Seems there's a bug in that yarn start-next script. For now, look at the deploy preview for version Next: https://deploy-preview-1409--calico-docs-preview-next.netlify.app/calico-cloud/next/reference/component-resources/configure-resources

@ctauchen
Copy link
Collaborator

ctauchen commented Apr 8, 2024

Your other build failures are caused by an error that we've fixed. A fetch and rebase should sort you out.

@vara2504
Copy link
Contributor Author

vara2504 commented Apr 9, 2024

@ctauchen Rebased with the latest change. And fix few bugs . Please take a look and let me know

@ctauchen
Copy link
Collaborator

ctauchen commented Apr 9, 2024

LGTM. Ready to merge?

@vara2504
Copy link
Contributor Author

vara2504 commented Apr 9, 2024

@ctauchen Yes. Should be good to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants