Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting for spec.registry example #861

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix formatting for spec.registry example #861

merged 3 commits into from
Sep 20, 2023

Conversation

KrisJohnstone
Copy link
Contributor

@tigera/docs,
Quick fix to indentation/formatting for the spec.registry example.

Product Version(s):
N/A - Just documentation fix.

DOCS review:

  • A member of the docs team has approved this change.

Merge checklist:
N/A doco change.

@KrisJohnstone KrisJohnstone requested a review from a team as a code owner August 11, 2023 01:59
@CLAassistant
Copy link

CLAassistant commented Aug 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Aug 11, 2023 •
edited
Loading

✅ Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit a425ee0
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/650a73abbb9a3a0007d85bca
😎 Deploy Preview https://deploy-preview-861--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 45 (🔴 down 3 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bmckercher123
Copy link
Contributor

bmckercher123 commented Aug 11, 2023 •
edited
Loading

Thanks for taking the time to submit this fix. Will get it reviewed shortly.

bmckercher123
bmckercher123 suggested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@bmckercher123 bmckercher123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrisJohnstone Looks good. Please copy to fixes to calico (root), for 3.27 and 3.25.

@bmckercher123 bmckercher123 added community-contributor Author is from outside of Tigera Needs docs review labels Aug 25, 2023
@KrisJohnstone
Copy link
Contributor Author

Bump

@bmckercher123
Copy link
Contributor

bmckercher123 commented Sep 11, 2023 •
edited
Loading

@KrisJohnstone Please rebase. It should get rid of the dead links that are showing in netlify build.

@bmckercher123 bmckercher123 merged commit 7d4946b into tigera:main Sep 20, 2023
5 checks passed
@KrisJohnstone KrisJohnstone deleted the fix-registry-example branch September 21, 2023 00:20
@KrisJohnstone KrisJohnstone mentioned this pull request Sep 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmckercher123 bmckercher123 bmckercher123 approved these changes

@lwr20 lwr20 Awaiting requested review from lwr20

Assignees
No one assigned
Labels
community-contributor Author is from outside of Tigera Needs docs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KrisJohnstone @CLAassistant @bmckercher123