Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use apiregistration/v1 #1258

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

bcreane
Copy link
Contributor

@bcreane bcreane commented Apr 15, 2021

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@bcreane bcreane changed the title [WIP] use v1 of apiregistration use apiregistration/v1 Apr 15, 2021
@bcreane bcreane removed the hold merge Do not merge label Apr 15, 2021
@tmjd
Copy link
Member

tmjd commented Apr 15, 2021

With what version of Kubernetes did the apiregistration/v1 become available?

@bcreane bcreane requested a review from tmjd April 15, 2021 19:18
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Looks like the apiregistration/v1 has been available since K8s 1.10 (https://raw.githubusercontent.com/kubernetes/kubernetes/release-1.10/api/openapi-spec/swagger.json) but it isn't in 1.9.

@bcreane bcreane merged commit 57ce1d8 into tigera:master Apr 15, 2021
@bcreane bcreane deleted the bcreane-apireg-update branch April 15, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants