Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kibana_login permissions to network admin cluster role #1976

Merged

Conversation

Brian-McM
Copy link
Contributor

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Brian-McM Brian-McM force-pushed the bm-add-kibana-login-to-net-admin branch from a973e75 to fdde929 Compare May 26, 2022 18:49
@Brian-McM Brian-McM force-pushed the bm-add-kibana-login-to-net-admin branch from fdde929 to 96af578 Compare May 27, 2022 17:58
@Brian-McM
Copy link
Contributor Author

/merge-when-ready delete-branch

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

@marvin-tigera marvin-tigera merged commit 79425de into tigera:master May 27, 2022
@marvin-tigera marvin-tigera deleted the bm-add-kibana-login-to-net-admin branch May 27, 2022 18:23
marvin-tigera added a commit that referenced this pull request May 30, 2022
…elease-v1.26

[release-v1.26] Auto pick #1976: Add kibana_login permissions to network admin cluster role
Brian-McM added a commit that referenced this pull request May 30, 2022
…elease-v1.25

[release-v1.25] Auto pick #1976: Add kibana_login permissions to network admin cluster role
marvin-tigera added a commit that referenced this pull request May 30, 2022
…elease-v1.27

[release-v1.27] Auto pick #1976: Add kibana_login permissions to network admin cluster role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants