Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.26] Auto pick #1976: Add kibana_login permissions to network admin cluster role #1979

Conversation

Brian-McM
Copy link
Contributor

Cherry pick of #1976 on release-v1.26.

#1976: Add kibana_login permissions to network admin cluster role

Original PR Body below

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marvin-tigera marvin-tigera merged commit a2654d7 into tigera:release-v1.26 May 30, 2022
@marvin-tigera marvin-tigera deleted the auto-pick-of-#1976-upstream-release-v1.26 branch May 30, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants