Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EGW icmp probes #2493

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Fix EGW icmp probes #2493

merged 2 commits into from
Feb 21, 2023

Conversation

sridhartigera
Copy link
Contributor

Description

EGW ICMP probes are failing with the below message

2023-02-21 20:57:24.076 [WARNING][7] egressd/icmp_probe.go 49: ICMP probe failed:
ping: socket: Operation not permitted
 ip=172.16.101.150 rc=2

Add NET_RAW capabilities to the EGW container to fix this.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@sridhartigera sridhartigera requested a review from a team as a code owner February 21, 2023 22:24
@marvin-tigera marvin-tigera added this to the v1.30.0 milestone Feb 21, 2023
rene-dekker
rene-dekker approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rene-dekker rene-dekker merged commit ee5d30d into tigera:master Feb 21, 2023
sridhartigera added a commit to sridhartigera/operator that referenced this pull request Feb 21, 2023
@sridhartigera
Fix EGW icmp probes (tigera#2493)
040ac1b 
* Fix EGW icmp probes
@sridhartigera sridhartigera mentioned this pull request Feb 21, 2023
Merged
5 tasks
marvin-tigera added a commit that referenced this pull request Feb 22, 2023
@marvin-tigera
Merge pull request #2496 from sridhartigera/sridhar-egw-icmp-pick
9913378 
Fix EGW icmp probes (#2493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiawei hjiawei hjiawei approved these changes

@rene-dekker rene-dekker rene-dekker approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sridhartigera @hjiawei @rene-dekker @marvin-tigera