migrate typha deployment affinities

[Tamas-Biro1]

Description

Tigera operator does not support podAffinity and podAntiAffinity during the migration from unmanaged Calico Typha deployment. This PR intended to add this feature.

For PR author

• Tests for change.
• If changing pkg/apis/, run make gen-files
• If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

• Milestone set according to targeted release.
• Appropriate labels:
  • kind/bug if this is a bugfix.
  • kind/enhancement if this is a a new feature.
  • enterprise if this PR applies to Calico Enterprise only.

[CLAassistant]

All committers have signed the CLA.

[tmjd]

CI hasn't ran and I'm not sure why, so I'm closing and reopening to see if that triggers CI.

[tmjd]

Looks like CI is not ran on PRs from external contributors.
I've ran the test target myself and see a failure that I was expecting might be the case.
I'd suggest running go test ./pkg/controller/migration/convert to see the issue.

[matthewdupre]

I enabled the CI - FYI @tmjd there should be a prompt next to where the results appear to allow the run. It might be a github permissions issue, although I'd have expected you'd be able to see/approve it too.

[tmjd]

I got distracted yesterday and forgot to submit these comments which are fairly trivial. I ran make test since CI isn't running and it all looks good.

[mgleung]

/sem-approve

[mgleung]

@Tamas-Biro1 it looks like there's a problem with some of our static checks. Could we ask you to run make gen-files to fix that?

[Tamas-Biro1]

@Tamas-Biro1 it looks like there's a problem with some of our static checks. Could we ask you to run make gen-files to fix that?

Running make gen-files does not change anything on the PR to me. What changes should i see?

[mgleung]

it looks like the issue is in the egress gateways CRD. Can you try make gen-crds? I thought everything should be under gen-files but it seems that CRD generation might not be.

[tmjd]

I've put up #2613 to address the issue @mgleung is talking about. Once it is merged you should be able to rebase your PR and then it will be fixed.

[tmjd]

#2613 has been merged so if you can update your branch it should allow CI to pass.

[Tamas-Biro1]

#2613 has been merged so if you can update your branch it should allow CI to pass.

yep, the branch has been rebased. thanks!

[mgleung]

/sem-approve

[tmjd]

LGTM

[tmjd]

Thank you for this change.