Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-v1.7 - Cherry-pick ClusterServiceVersion tooling #757

Merged
merged 5 commits into from
Aug 7, 2020

Conversation

lmm
Copy link
Contributor

@lmm lmm commented Jul 24, 2020

Description

Pick of:

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@lmm lmm added this to the v1.7.3 milestone Jul 24, 2020
@lmm lmm marked this pull request as draft July 25, 2020 01:03
@lmm lmm marked this pull request as ready for review August 7, 2020 20:16
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmm lmm merged commit b2c5f84 into tigera:release-v1.7 Aug 7, 2020
@lmm lmm deleted the lmm-v1.7-pick branch August 7, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants