Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit release script gracefully if not on a tag #761

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

lmm
Copy link
Contributor

@lmm lmm commented Jul 24, 2020

Description

I think this will fix the release script now failing with exit code 1 due to the addition of set -e

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmjd tmjd merged commit 53dbd70 into tigera:master Jul 24, 2020
lmm pushed a commit to lmm/operator that referenced this pull request Jul 25, 2020
Exit release script gracefully if not on a tag
@lmm lmm deleted the lmm-fix-release-script branch August 7, 2020 19:54
lmm pushed a commit to lmm/operator that referenced this pull request Aug 7, 2020
Exit release script gracefully if not on a tag
lmm pushed a commit to lmm/operator that referenced this pull request Aug 7, 2020
Exit release script gracefully if not on a tag
lmm added a commit that referenced this pull request Aug 7, 2020
* Add ClusterServiceVersion bundling (#682)

* Update docs links in clusterserviceversion template

* Use operator-sdk v0.10.1 for everything but CSV gen

CSV gen will use v0.18.2

* Merge pull request #761 from lmm/lmm-fix-release-script

Exit release script gracefully if not on a tag

* Tag and push release images to RedHat Connect for validation (#688)

Co-authored-by: Erik Stidham <erik@tigera.io>
lmm pushed a commit to lmm/operator that referenced this pull request Aug 25, 2020
Exit release script gracefully if not on a tag
lmm added a commit that referenced this pull request Aug 25, 2020
* Add ClusterServiceVersion bundling (#682)

* Tag and push release images to RedHat Connect for validation (#688)

* Merge pull request #761 from lmm/lmm-fix-release-script

Exit release script gracefully if not on a tag

* Fix version in image tag (#818)

Co-authored-by: Erik Stidham <erik@tigera.io>
lmm pushed a commit to lmm/operator that referenced this pull request Aug 28, 2020
Exit release script gracefully if not on a tag
lmm added a commit that referenced this pull request Sep 11, 2020
* Tag and push release images to RedHat Connect for validation (#688)

* Merge pull request #761 from lmm/lmm-fix-release-script

Exit release script gracefully if not on a tag

* Fix version in image tag (#818)

Co-authored-by: Erik Stidham <erik@tigera.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants