Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick CSV generation tooling into release-v1.10 #855

Merged
merged 4 commits into from Aug 25, 2020

Conversation

lmm
Copy link
Contributor

@lmm lmm commented Aug 25, 2020

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@lmm lmm added this to the v1.10.0 milestone Aug 25, 2020
@lmm lmm marked this pull request as ready for review August 25, 2020 17:36
@lmm lmm changed the title Cherry-picks into release-v1.10 Cherry-pick CSV generation tooling into release-v1.10 Aug 25, 2020
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmm lmm merged commit e0cc1d3 into tigera:release-v1.10 Aug 25, 2020
@lmm lmm deleted the lmm-v1.10-pick branch August 26, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants