ci: implement release verification #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
commented
Nov 3, 2023
src/scripts/ci.zig
Outdated
Comment on lines
129
to
130
| // TODO: these two don't work yet | ||
| if (language == .go or language == .dotnet) continue; |
There was a problem hiding this comment.
Yes, these two are broken! Looking into fixing them, but want to do that independently from this work to add basic verification.
cb22
reviewed
Nov 3, 2023
src/testing/tmp_tigerbeetle.zig
Outdated
| _ = try shell.project_root.statFile(tigerbeetle_exe); | ||
| }; | ||
| // If tigerbeetle binary does not exist yet, build it. | ||
| // TODO: just run `zig build run` unconditionally here, when that doesn't do spurious rebuilds. |
There was a problem hiding this comment.
@matklad tidy.zig complaining about line length here
matklad
force-pushed
the
matklad/validate-release
branch
from
6b8af43
to
042098e
Compare
|
fix for go: #1265 |
matklad
added a commit
that referenced
this pull request
Nov 6, 2023
See dotnet/sdk#12160 (comment) I don't entirely understand what's happening here, but adding this flag indeed results into native libraries included in the archive. This should be caught by #1264 in the future
|
and for .net! |
matklad
force-pushed
the
matklad/validate-release
branch
2 times, most recently
from
5a96d23
to
e2bc88d
Compare
matklad
force-pushed
the
matklad/validate-release
branch
from
5f4b90e
to
338be3f
Compare
batiati
reviewed
Nov 8, 2023
src/clients/java/ci.zig
Outdated
| \\ <dependency> | ||
| \\ <groupId>com.tigerbeetle</groupId> | ||
| \\ <artifactId>tigerbeetle-java</artifactId> | ||
| \\ <version>0.14.158</version> |
There was a problem hiding this comment.
Shouldn't we use the targetted version here?
Suggested change
| \\ <version>0.14.158</version> | |
| \\ <version>{version}</version> |
There was a problem hiding this comment.
Most excellent catch, thanks!
Fun fact, when writing this code I've actually thought that options: struct pattern has a drawback that it doesn't warn about unused field, as I made a similar mistake for some other language!
matklad
force-pushed
the
matklad/validate-release
branch
3 times, most recently
from
144379d
to
65aeeb2
Compare
This adds last-mile testing of the thing that was actually released (GitHub release, nmp package, etc). This is too late to _prevent_ issues, but helps to discover things otherwise impossible to discover (eg, some files were lost during upload to GitHub), and also helps with finding divergence of upstream dependencies (e.g., if something breaks on a new version of node js).
matklad
force-pushed
the
matklad/validate-release
branch
from
65aeeb2
to
4ccccb7
Compare
batiati
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds last-mile testing of the thing that was actually released (GitHub release, nmp package, etc). This is too late to prevent issues, but helps to discover things otherwise impossible to discover (eg, some files were lost during upload to GitHub), and also helps with finding divergence of upstream dependencies (e.g., if something breaks on a new version of node js).