dotnet: include native libraries into .nupkg archive #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, so this includes something in the archive, but that doesn't look reasonable at all:0 Yes, |
matklad
force-pushed
the
matklad/repair-dotnet
branch
from
fa84258
to
9fd82ac
Compare
At the moment, our dotnet packages doesn't actually include TigerBeetle native libraries. Unfortunate! I think I've debugged this, the explanation is found here: <https://learn.microsoft.com/en-us/visualstudio/msbuild/customize-builds-for-generated-files?view=vs-2022> > Files generated during execution don't exist during the evaluation > phase, therefore they aren't included in the build process. I think that's exactly what happens here: as written, msbuild expands the glob from `<Content Include="runtimes\**\*.so">` in evaluation phase, that is, before we run the code to generate those files. So, it happily includes an empty set of files! We need to force MS Build to expand the glob _after_ the generation task is run. Apparently, including the `ItemGroup` into the task is the way to go here?
matklad
force-pushed
the
matklad/repair-dotnet
branch
from
9fd82ac
to
677989d
Compare
batiati
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, our dotnet packages doesn't actually include TigerBeetle native libraries. Unfortunate!
I think I've debugged this, the explanation is found here:
https://learn.microsoft.com/en-us/visualstudio/msbuild/customize-builds-for-generated-files?view=vs-2022
I think that's exactly what happens here: as written, msbuild expands the glob from
<Content Include="runtimes\**\*.so">in evaluation phase, that is, before we run the code to generate those files. So, it happily includes an empty set of files!We need to force MS Build to expand the glob after the generation task is run. Apparently, including the
ItemGroupinto the task is the way to go here?