ci: smoke-run simulator on CI #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
force-pushed
the
matklad/not-a-rocket
branch
from
32f8445
to
9605e83
Compare
Comment on lines
+223
to
+225
| - run: zig/zig build simulator_run -Dsimulator-state-machine=accounting -Doptimize=ReleaseSafe -- ${{ github.sha }} | ||
| - run: zig/zig build simulator_run -Dsimulator-state-machine=testing -Doptimize=ReleaseSafe -- ${{ github.sha }} |
There was a problem hiding this comment.
🤔 Should we use the PR number instead? That way you can't "fix" a failing seed by just force-pushing with a different commit message.
There was a problem hiding this comment.
I think I like commit hash more, as it is more hermetic. It is a bit more fragile, but hopefully everyone is diligent enough to create a follow-up issue anyway!
There was a problem hiding this comment.
Hermetic in a sense that you only need commit hash for a repro: with PR number, you still need commit hash, but you also need PR, which also is a tie to GitHub
sentientwaffle
previously approved these changes
Nov 7, 2023
.github/workflows/linux.yml
Outdated
| # It would be a good idea to also _run_ a single iteration, | ||
| # but that currently has some false failures :-) | ||
| # TODO: Make so we have a single zig build simulator that does both | ||
| # Run simulator once, using commit hash as a random, but also deterministic seed. |
There was a problem hiding this comment.
Nit: once (per state machine)
Normally, a seed is specified as a base-10 integer. However, as a special case, we allow using a Git hash (a hex string 40 character long). This is used by our CI, which passes current commit hash as a seed --- that way, we run simulator on CI, we run it with different, "random" seeds, but the the failures remain reproducible just from the commit hash!
matklad
force-pushed
the
matklad/not-a-rocket
branch
from
9605e83
to
c7ce5a9
Compare
sentientwaffle
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, a seed is specified as a base-10 integer. However, as a special case, we allow using a Git hash (a hex string 40 character long). This is used by our CI, which passes current commit hash as a seed --- that way, we run simulator on CI, we run it with different, "random" seeds, but the the failures remain reproducible just from the commit hash!