Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exit repl on 'help' #1397

Merged
merged 1 commit into from Dec 31, 2023
Merged

Don't exit repl on 'help' #1397

merged 1 commit into from Dec 31, 2023

Conversation

brson
Copy link
Contributor

@brson brson commented Dec 29, 2023

One of the first things I did with tigerbeetle, per the docs, was run the repl, and the first thing I did in the repl was type 'help', which immediately exited the repl.

I thought this behavior was surprising (e.g. the python repl doesn't exit on help), and I couldn't find an obvious reason for it in the code or the commit log.

This change just removes the call to exit, so the repl continues to run after displaying the help message.

@brson
Copy link
Contributor Author

brson commented Dec 29, 2023

CI failure looks unrelated to me.

@matklad
Copy link
Member

matklad commented Dec 30, 2023

Yeah, makes sense! In general, our repl exists, but is not good, there should be plenty of low-hanging fruit there (and one rather hard to crack coconut as well: on the one hand, we'd love to have readline conveniences, on the other hand, we are not thrilled about linking to readline or implementing the required functionality ourselves).

Will look into CI failure, it is indeed unrelated: we try to test that our client library is installable on different distros, but that turns into an exercise of installing node itself, and apparently something broke there?

@matklad
Copy link
Member

matklad commented Dec 30, 2023

See #1398 for CI failure fix.

@matklad matklad added this pull request to the merge queue Dec 31, 2023
Merged via the queue into tigerbeetle:main with commit 1eeb532 Dec 31, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants