node: prune down CI #1398
Merged
node: prune down CI #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For NodeJS, we used to have a hefty matrix of different distributions, to make sure our stuff works in all possible contexts. However, it looks like the main thing we are testing here is installing node itself --- we used something called `nodesource` which provides third party packages for various distros, and requires add-hoc scripts for installation. This is also something that was changed recently (they used to have a single script, which is now deprecated). And it looks like it broke again: https://github.com/tigerbeetle/tigerbeetle/actions/runs/7359371489/job/20034038580?pr=1397#step:5:573 It feels like here we are taking onto us some else's maintainance burden. I'd say that, if official node does not provide one-liner installation for these distros, we shouldn't invent our own wheel. Let's just check that the two official images from NodeJS work, it feels to be a better balance of coverage vs maintainance work!
batiati
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NodeJS, we used to have a hefty matrix of different distributions, to make sure our stuff works in all possible contexts. However, it looks like the main thing we are testing here is installing node itself --- we used something called
nodesourcewhich provides third party packages for various distros, and requires add-hoc scripts for installation. This is also something that was changed recently (they used to have a single script, which is now deprecated). And it looks like it broke again:https://github.com/tigerbeetle/tigerbeetle/actions/runs/7359371489/job/20034038580?pr=1397#step:5:573
It feels like here we are taking onto us some else's maintainance burden. I'd say that, if official node does not provide one-liner installation for these distros, we shouldn't invent our own wheel.
Let's just check that the two official images from NodeJS work, it feels to be a better balance of coverage vs maintainance work!