Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScanLevel manifest status and assertions. #1824

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

batiati
Copy link
Contributor

@batiati batiati commented Apr 4, 2024

Fine, I got confused by my own code 🤦‍♂️ !!
Since I had to make sense of this logic again, let's refactor the status and assertions to make it more evident when the iterator moves to the next TableInfo instead of using a misleading fetch_pending boolean flag.

@batiati batiati added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 896b2b3 Apr 4, 2024
26 checks passed
@batiati batiati deleted the batiati-scan-level-assert branch April 4, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants