tree_fuzz: fix false positive #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1_000 was an out of thin air constant I used for testing, lets use the correct value here Seed: ./zig/zig build -Drelease fuzz -- --seed=8888456137543307989 lsm_tree
src/lsm/tree_fuzz.zig
Outdated
| u32, | ||
| events_max * @sizeOf(Value), | ||
| NodePool.node_size, | ||
| ) catch unreachable; |
There was a problem hiding this comment.
Fyi we have a stdx.div_ceil that doesn't return an error. (It asserts that the denominator is nonzero.)
There was a problem hiding this comment.
Ahhhh, I had a vague recollection of that, but grepped for divCeil which didtt' help 🤣
sentientwaffle
previously approved these changes
May 2, 2024
matklad
force-pushed
the
matklad/tree-failure
branch
from
72ebbcf
to
24632c9
Compare
sentientwaffle
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1_000 was an out of thin air constant I used for testing, lets use the correct value here
Seed: ./zig/zig build -Drelease fuzz -- --seed=8888456137543307989 lsm_tree