Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specifying custom build destination #76

Closed
wants to merge 1 commit into from
Closed

Add specifying custom build destination #76

wants to merge 1 commit into from

Conversation

vmitchell85
Copy link

Added an option to specify a different folder destination name

Added an option to specify a different folder destination name
@erickpatrick
Copy link
Contributor

And, once again, we have this one on master. This can be closed.

@vmitchell85
Copy link
Author

@erickpatrick Thanks for the info... I found it in an old PR but not in the docs, which I searched for before creating this PR.

I think I'd still prefer the command line option though, instead of specifying in config.php.

However I hear Jigsaw is undergoing a lot or changes so I don't think this will matter much.

@damiani
Copy link
Contributor

damiani commented Mar 23, 2017

@vmitchell85 We had several people express a need for customizing the source/destination locations, such that making it a permanent config option—which could also be customized by environment—seemed like a user-friendly and worthwhile feature. I left this open, though so that once the master branch is tagged as a release, we could discuss updating your PR to add it as a command line option as well. I can see valid use cases for both approaches.

@damiani
Copy link
Contributor

damiani commented Aug 2, 2017

I think we'll stick with the config-based setting for now, haven't encountered a compelling reason to add it as a command line option.

@damiani damiani closed this Aug 2, 2017
@vmitchell85
Copy link
Author

Thanks for taking the time to consider it.

I've changed my process since the rewrite to use the config option... so it's no longer an issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants