-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ordering issue with passthrough parameters #302
Conversation
Hey, @mattstauffer @tonysm ! Can you review that please? |
I'll check it tomorrow (it looks good, but the build is not passing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🔥
@josecanhelp @devsquad-alvaro-meireles one question: I think the original feature allowed passing arguments to the container process, but with this change, the passthrough feature is now for docker run options, or am I reading this wrong? 🤔 before: docker run image {container-args} after: docker run {docker-run-options} image |
@tonysm that seems right. I thought the pass through was for docker run commands, not container processes. |
@josecanhelp maybe we should offer a new option for the run command options, something like: takeout enable mysql --run="--restart unless-stopped -e 'LOREM=IPSUM'" -- -hsome.mysql.host -usome-mysql-user -p where it would generate a command like: docker run {other-options} --restart unless-stopped -e 'LOREM=IPSUM' mysql -hsome.mysql.host -usome-mysql-user -p |
@tonysm The main idea that I've asked in #301 was the ability to set a custom volume to be shareable with the container, so we can easily share a database dump to the MySQL container |
We could offer the extra So, I'd be more inclined to offer a single option for power users to pass any docker run options to the docker run command underneath. Thoughts? |
Sounds good! 🚀 |
Alright, so I'll revert this change and introduce a new |
Thanks, @tonysm! |
The v2.2.0 tag was released with the new |
Passthrough parameters were being added to the end of the run commands, after the image name and tag. However, those parameters should be passed through to the command before that. The simplest solution, in my opinion, is to reorder those strings at the base command enable function. I tested this with passing custom ports as well as custom volumes.
This PR would resolve #299 as well as #301.