Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a --run option to the enable command #304

Merged
merged 9 commits into from
Nov 18, 2022
Merged

Conversation

tonysm
Copy link
Contributor

@tonysm tonysm commented Nov 18, 2022

Changed

Added

  • Adds a new --run option to the enable command which can be used to pass any extra docker run option

This is how we can use this:

takeout enable mysql --run="--restart unless-stopped -e 'LOREM=IPSUM'" -- -h127.0.0.1 -usome-user

This will be translated to a docker command like this:

docker run --restart unless-stopped -e 'LOREM=IPSUM' {service-options} mysql -h127.0.0.1 -usome-user

where {service-options} depends on the options defined in the service class.

Copy link
Member

@driftingly driftingly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good @tonysm!
We'll need to document this and how to pass through additional options -- when we tag the next release.

@tonysm tonysm merged commit 731d5de into main Nov 18, 2022
@tonysm tonysm deleted the feature/tm-enable-run-options branch November 18, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants