Add missing using directive and extension method for converting ubiquitous series to a strongly typed collection #60
Conversation
joakimhew
changed the title
|
|
||
| foreach (var serie in series) | ||
| { | ||
| var properties = t.GetProperties(BindingFlags.Instance | BindingFlags.Public).ToList(); |
There was a problem hiding this comment.
Possibly add some reflection caching for faster converting.
|
Hey man, thanks a lot for the PR. I'll try to test it out over the weekend and then deploy it to nuget. Cheers! |
|
Hey man. Just glad if I can help. I forgot to check if it's compatible with both target frameworks. I know some reflection is different in .NET Standard 2.0 so if you haven't already checked it I'll go through it in a bit. |
|
Haven't looked at it yet. If you have the time and will, go for it. :) |
|
@pootzko All good 👍 |
|
Also great stuff, thanks! |
| Type t = typeof(T); | ||
|
|
||
| foreach (var serie in series) | ||
| { |
There was a problem hiding this comment.
@pootzko One thing worth noting is that even though it iterates through all series the extensions expects each serie to match the structure of the type provided in 'T'. I'll see if I can come up with a solution to support different structured series. Cheers
There was a problem hiding this comment.
I think that's fine. The end-user should take care of this in my opinion. The only situation where it could get a bit mess is if someone is using the MultiQuery to fetch different series.
No description provided.