Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waypipe: rebase patch on the latest release #633

Merged
merged 1 commit into from
May 24, 2024
Merged

waypipe: rebase patch on the latest release #633

merged 1 commit into from
May 24, 2024

Conversation

Mic92
Copy link
Collaborator

@Mic92 Mic92 commented May 24, 2024

The latest release also has a "title-prefix" feature which is also very handy to i.e. prefix the VM name to an application. I haven't tested the patch yet, since I am currently missing
a machine for that.

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 09:31 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 09:32 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 09:32 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 09:32 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 09:36 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 09:36 — with GitHub Actions Inactive
@Mic92 Mic92 marked this pull request as draft May 24, 2024 09:47
@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 09:54 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 09:54 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 09:55 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 09:55 — with GitHub Actions Inactive
@Mic92 Mic92 marked this pull request as ready for review May 24, 2024 09:57
@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 10:05 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow May 24, 2024 10:05 — with GitHub Actions Inactive
The latest release also has a "title-prefix" feature which is also very
handy to i.e. prefix the VM name to an application.

Signed-off-by: Jörg Thalheim <joerg@thalheim.io>
@Mic92
Copy link
Collaborator Author

Mic92 commented May 24, 2024

I tested that the command-line parsing itself still works:

/nix/store/f1diwdf3h6d664h18mk52hhxayzs7xsk-waypipe-0.9.0/bin/waypipe --border #ff5733,5 server /home/joerg/.nix-profile/bin/foot

Copy link
Member

@humaidq-tii humaidq-tii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on X1 carbon, works as expected

@brianmcgillion brianmcgillion merged commit 39f59d6 into main May 24, 2024
14 checks passed
@brianmcgillion brianmcgillion deleted the waypipe branch May 24, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants