ErrQueryInterrupted with parameters #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ekexium <eke@fastmail.com>
zyguan
approved these changes
Jan 18, 2024
MyonKeminta
reviewed
Jan 19, 2024
13 tasks
cfzjywxk
approved these changes
Feb 2, 2024
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Feb 18, 2024
* feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Feb 18, 2024
* feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
cfzjywxk
added a commit
that referenced
this pull request
Feb 19, 2024
* feat: check kill signal in 2pc committer (#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (#1102)" (#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
ti-chi-bot
added
needs-cherry-pick-release-7.1
and removed
needs-cherry-pick-release-7.1
labels
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Feb 27, 2024
* feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
ekexium
added a commit
that referenced
this pull request
Feb 27, 2024
* fix: check kill signal against 0 (#1102) * fix: check kill signal against 0, so that all kill signals will not be ignored. Signed-off-by: ekexium <eke@fastmail.com> * refactor: extract method checkKilled() Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> * ErrQueryInterrupted with parameters (#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (#1102)" (#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> * rm backoff.go Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> Signed-off-by: zzm <zhouzemin@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref pingcap/tidb#49643
We have to return the error with the signal to enable TiDB to convert it to the actual error type.