fix: check kill signal against 0 #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ignored. Signed-off-by: ekexium <eke@fastmail.com>
ekexium
force-pushed
the
check-kill-signal-in-committer-2
branch
from
c0e822d
to
3521491
Compare
|
Why are there two identical |
cfzjywxk
reviewed
Jan 4, 2024
cfzjywxk
reviewed
Jan 4, 2024
ekexium
force-pushed
the
check-kill-signal-in-committer-2
branch
from
d2141b3
to
15d27cb
Compare
Signed-off-by: ekexium <eke@fastmail.com>
ekexium
force-pushed
the
check-kill-signal-in-committer-2
branch
from
15d27cb
to
83c820b
Compare
zyguan
approved these changes
Jan 5, 2024
I guess the |
cfzjywxk
approved these changes
Jan 5, 2024
|
@ekexium Please update the branch |
MyonKeminta
added a commit
to MyonKeminta/client-go
that referenced
this pull request
Jan 23, 2024
This reverts commit 057c479.
MyonKeminta
added a commit
to MyonKeminta/client-go
that referenced
this pull request
Jan 23, 2024
This reverts commit 057c479. Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
MyonKeminta
added a commit
that referenced
this pull request
Jan 23, 2024
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Jan 29, 2024
cfzjywxk
added a commit
that referenced
this pull request
Feb 2, 2024
* feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (#1102)" (#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Feb 18, 2024
* feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Feb 18, 2024
* feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
cfzjywxk
added a commit
that referenced
this pull request
Feb 19, 2024
* feat: check kill signal in 2pc committer (#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (#1102)" (#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Feb 27, 2024
* fix: check kill signal against 0, so that all kill signals will not be ignored. Signed-off-by: ekexium <eke@fastmail.com> * refactor: extract method checkKilled() Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Feb 27, 2024
* feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
ekexium
added a commit
that referenced
this pull request
Feb 27, 2024
* fix: check kill signal against 0 (#1102) * fix: check kill signal against 0, so that all kill signals will not be ignored. Signed-off-by: ekexium <eke@fastmail.com> * refactor: extract method checkKilled() Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> * ErrQueryInterrupted with parameters (#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (#1102)" (#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> * rm backoff.go Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> Signed-off-by: zzm <zhouzemin@pingcap.com>
iosmanthus
pushed a commit
that referenced
this pull request
Mar 13, 2024
Co-authored-by: zzm <zhouzemin@pingcap.com> Co-authored-by: glorv <glorvs@163.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: ekexium <eke@fastmail.com> Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com> Co-authored-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> Co-authored-by: Evan Zhou <coocood@gmail.com> Co-authored-by: iosmanthus <dengliming@pingcap.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: jinhelin <linjinhe33@gmail.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com> Co-authored-by: Ping Yu <yuping@pingcap.com> fix: check kill signal against 0 (#1102)" (#1129)" fix safepoint kv with keyspace name (#928) fix encoding of mvcc get by key (#775) close on canceled (#1121) Fix wait recvloop timeout (#1134) CloseAddr (#1140) Fix timeout of TestResolveTxnFallbackFromAsyncCommit (#1146)
iosmanthus
added a commit
that referenced
this pull request
Jul 9, 2024
Co-authored-by: zzm <zhouzemin@pingcap.com> Co-authored-by: glorv <glorvs@163.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: ekexium <eke@fastmail.com> Co-authored-by: Liqi Geng <gengliqiii@gmail.com> Co-authored-by: zyguan <zhongyangguan@gmail.com> Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: crazycs <crazycs520@gmail.com> fix: check kill signal against 0 (#1102)" (#1129)" fix #1111 (#1324) fix rpc client panic cause by concurrent close (#1358)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the kill signal was checked against
1, however TiDB uses non-zero values to indicate a kill signal.