Use correct address for CloseAddr #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
pingyu
changed the title
iosmanthus
approved these changes
Jan 26, 2024
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* wip Signed-off-by: Ping Yu <yuping@pingcap.com> * CloseAddr with ver Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ErrConn Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ut Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> --------- Signed-off-by: Ping Yu <yuping@pingcap.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* wip Signed-off-by: Ping Yu <yuping@pingcap.com> * CloseAddr with ver Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ErrConn Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ut Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> --------- Signed-off-by: Ping Yu <yuping@pingcap.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* wip Signed-off-by: Ping Yu <yuping@pingcap.com> * CloseAddr with ver Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ErrConn Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ut Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> --------- Signed-off-by: Ping Yu <yuping@pingcap.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* wip Signed-off-by: Ping Yu <yuping@pingcap.com> * CloseAddr with ver Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ErrConn Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ut Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> --------- Signed-off-by: Ping Yu <yuping@pingcap.com> Signed-off-by: zzm <zhouzemin@pingcap.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Mar 13, 2024
* wip Signed-off-by: Ping Yu <yuping@pingcap.com> * CloseAddr with ver Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ErrConn Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ut Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> --------- Signed-off-by: Ping Yu <yuping@pingcap.com>
iosmanthus
pushed a commit
that referenced
this pull request
Mar 13, 2024
Co-authored-by: zzm <zhouzemin@pingcap.com> Co-authored-by: glorv <glorvs@163.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: ekexium <eke@fastmail.com> Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com> Co-authored-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> Co-authored-by: Evan Zhou <coocood@gmail.com> Co-authored-by: iosmanthus <dengliming@pingcap.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: jinhelin <linjinhe33@gmail.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com> Co-authored-by: Ping Yu <yuping@pingcap.com> fix: check kill signal against 0 (#1102)" (#1129)" fix safepoint kv with keyspace name (#928) fix encoding of mvcc get by key (#775) close on canceled (#1121) Fix wait recvloop timeout (#1134) CloseAddr (#1140) Fix timeout of TestResolveTxnFallbackFromAsyncCommit (#1146)
pingyu
added a commit
to pingyu/client-go
that referenced
this pull request
Mar 13, 2024
* wip Signed-off-by: Ping Yu <yuping@pingcap.com> * CloseAddr with ver Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ErrConn Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ut Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> --------- Signed-off-by: Ping Yu <yuping@pingcap.com>
pingyu
added a commit
that referenced
this pull request
Mar 14, 2024
* close on canceled (#1121) Signed-off-by: Ping Yu <yuping@pingcap.com> * Fix wait recvloop timeout (#1134) * wip Signed-off-by: Ping Yu <yuping@pingcap.com> * CloseAddr with ver Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ErrConn Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ut Signed-off-by: Ping Yu <yuping@pingcap.com> * cleanup Signed-off-by: Ping Yu <yuping@pingcap.com> --------- Signed-off-by: Ping Yu <yuping@pingcap.com> * Use correct address for CloseAddr (#1140) * wip Signed-off-by: Ping Yu <yuping@pingcap.com> * CloseAddr with ver Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ErrConn Signed-off-by: Ping Yu <yuping@pingcap.com> * fix ut Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> * polish Signed-off-by: Ping Yu <yuping@pingcap.com> --------- Signed-off-by: Ping Yu <yuping@pingcap.com> * rebase Signed-off-by: Ping Yu <yuping@pingcap.com> --------- Signed-off-by: Ping Yu <yuping@pingcap.com> Co-authored-by: iosmanthus <dengliming@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1141
Changes
ErrConnto wrap connection error and get target address and version of theconnArrayon which raise the error.ErrConnforCloseAddrvertoconnArrayto avoid unnecessary closing due to concurrent read/write onconnArray.