region_cache: in some cases, LocateBucket should not return nil. #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
youjiali1995
approved these changes
May 7, 2022
cfzjywxk
reviewed
May 7, 2022
| // it will return Bucket{KeyLocation.StartKey, first Bucket key} rather than nil --- it's reasonable to assume that | ||
| // Bucket{KeyLocation.StartKey, first Bucket key} is a bucket belonging to the region. Key in [last Bucket key, KeyLocation.EndKey) | ||
| // is handled similarly. | ||
| func (l *KeyLocation) LocateBucketV2(key []byte) *Bucket { |
There was a problem hiding this comment.
What does V2 suppose to mean? Does that mean there would be two versions of the LocateBucket function and they would be used in different situations? If so it's better to change the name to some meaningful name but not use V2.
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When key is in [region startkey, first bucket key) or [last bucket key, region endkey), it's better not to return nil, as they can be considered to be
Bucket.