add replica read adjuster function in KVSnapshot #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: glorv <glorvs@163.com>
glorv
force-pushed
the
adjust-replica-read
branch
from
c20dcc6
to
c83ad4a
Compare
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
|
@disksing @youjiali1995 PTAL |
youjiali1995
approved these changes
Jul 7, 2022
disksing
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pingcap/tidb#35927 introduced a new follower read type
closest-adaptiveto allow send request to the nearest replica based on the response size. This can help minimize the overhead of the extra readIndex raft propose when the request is small. This PR add a new checker function in KVSnapshot so we can also apply this logic to Get/BatchGet requests.