fix data race #736
Merged
fix data race #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Smityz <smityz@qq.com>
|
@disksing Hi master, could you please help me to review this fix? It is only related to unit testing. |
you06
pushed a commit
to you06/client-go
that referenced
this pull request
Jun 27, 2023
Signed-off-by: Smityz <smityz@qq.com> Co-authored-by: disksing <i@disksing.com>
you06
pushed a commit
to you06/client-go
that referenced
this pull request
Jun 27, 2023
Signed-off-by: Smityz <smityz@qq.com> Co-authored-by: disksing <i@disksing.com> Signed-off-by: you06 <you1474600@gmail.com>
cfzjywxk
pushed a commit
that referenced
this pull request
Jun 28, 2023
#846) * reload region cache when store is resolved from invalid Signed-off-by: you06 <you1474600@gmail.com> * reload region once Signed-off-by: you06 <you1474600@gmail.com> * build in go1.18 Signed-off-by: you06 <you1474600@gmail.com> * build in go1.18 Signed-off-by: you06 <you1474600@gmail.com> * handle region reload in resolve goroutine Signed-off-by: you06 <you1474600@gmail.com> * retest Signed-off-by: you06 <you1474600@gmail.com> * fix data race (#736) Signed-off-by: Smityz <smityz@qq.com> Co-authored-by: disksing <i@disksing.com> Signed-off-by: you06 <you1474600@gmail.com> * build with go 1.18 Signed-off-by: you06 <you1474600@gmail.com> * fix integration test (#673) Signed-off-by: disksing <i@disksing.com> Signed-off-by: you06 <you1474600@gmail.com> * Update internal/locate/region_cache.go Co-authored-by: crazycs <crazycs520@gmail.com> Signed-off-by: you06 <you1474600@gmail.com> * address comment Signed-off-by: you06 <you1474600@gmail.com> * address comment Signed-off-by: you06 <you1474600@gmail.com> --------- Signed-off-by: you06 <you1474600@gmail.com> Signed-off-by: Smityz <smityz@qq.com> Signed-off-by: disksing <i@disksing.com> Co-authored-by: Smilencer <smityz@qq.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: crazycs <crazycs520@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #735