remove protobuf-build completely #545
Labels
Comments
Merged
Merged
BusyJay
added a commit
that referenced
this issue
Nov 1, 2022
Since 0.11, prost-build never bundles protoc binary anymore. To avoid requiring protoc for grpcio-proto users, we bundle the sources instead of generating at compile time. This can lead to potential problems like: - Miss match version between generating tools and runtime - Repository becomes bloated But there seems to be no better alternative. Since this PR when using prost with grpcio, protoc is also required in PATH. This PR also removes protobuf-build dependencies. From now on, it will be easier to publish new version of grpcio-compiler. Close #545. Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
grpcio-proto depends on protobuf-build to build dependency, protobuf-build depends on grpcio-compiler, hence cause circular dependency. It's not easy to maintain.
Describe the solution you'd like
Remove protobuf-build completely. Instead, using custom scripts to generate files instead.
The text was updated successfully, but these errors were encountered: