-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gRPC to 1.7.2 #113
Update gRPC to 1.7.2 #113
Conversation
grpc-sys/build.rs
Outdated
@@ -104,7 +104,7 @@ fn build_grpc(cc: &mut Build, library: &str) { | |||
} else { | |||
println!("cargo:rustc-link-search=native={}", build_dir); | |||
println!( | |||
"cargo:rustc-link-search=native={}/third_party/cares", | |||
"cargo:rustc-link-search=native={}/third_party/cares/cares/lib", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L85 should also be modified. Maybe you can move it out from the if-else block.
any performance improved? |
@siddontang No results yet, the benchmark is broken again, I need more time to fix it. |
How about the performance of TiKV? |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI failed @overvenus |
CC #107