Test cases: #[trace] async fn a(mut b)

[taqtiqa-mark]

#[minitrace::trace("a", enter_on_poll = true)]
async fn a(mut b: String) {
    c(&mut b)
}

fn c(d: &mut String) {
    d;
}

gives this error, which is resolved per this comment:

173 | async fn a(mut b: String) {
    |                - help: consider changing this to be mutable: `mut b`
174 |     c(&mut b)
    |       ^^^^^^ cannot borrow as mutable

error[E0596]: cannot borrow `client` as mutable, as it is not declared as mutable

Remove the trace macro and the error goes away.

For anyone caught out, until a fix lands, the workaround should have no performance impact (should be optimized by the compiler):

async fn a( b: String) {
   let mut b = b;
    c(&mut b)
}

Note the synchronous version appears to survive intact:

#[minitrace::trace("a")]
fn a(mut b: String) {
    c(&mut b)
}

fn c(d: &mut String) {
    d;
}

Test cases related to issue #81.

[andylokandy]

I believe the issue comes from this statement, although I haven't had a machine to test it now:

minitrace-rust/minitrace-macro/src/lib.rs

Line 268 in ede1ec5

ident.mutability = None;

And frankly speaking, I don't know why this statement is here 🤣 because it's all copy-and-pasted from crate async-trait. I guess it's an async-trait specific constraint and we can simply remove it.

[taqtiqa-mark]

Testing now. That change does resolve the issue. I'll leave this open as test cases to be implemented.

[taqtiqa-mark]

Closed by PR #119