Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code coverage of minitrace-macro #81

Closed
zhongzc opened this issue Jan 26, 2022 · 1 comment
Closed

Improve code coverage of minitrace-macro #81

zhongzc opened this issue Jan 26, 2022 · 1 comment
Labels
help wanted Extra attention is needed
Milestone
Initial Publish

Comments

@zhongzc
Copy link
Collaborator

zhongzc commented Jan 26, 2022

Only 66.3% now. Hope increasing it up to 85%.

See: https://coveralls.io/builds/45965582/source?filename=minitrace-macro%2Fsrc%2Flib.rs
@zhongzc zhongzc added the help wanted Extra attention is needed label Jan 26, 2022
@breezewish breezewish added this to the Community Initial Publish milestone Jan 27, 2022
This was referenced Mar 15, 2022
Closed
Closed
Merged
taqtiqa-mark added a commit to taqtiqa-mark/utrace-rust that referenced this issue Mar 21, 2022
@taqtiqa-mark
Add: Legacy procedural macro integration tests
b130ba9 
Address issue tikv#81.

These tests reflect the current state of play.

They ensure migrating to the pipeline set out in issue tikv#113,
does not break existing functionality.

Signed-off-by: Mark Van de Vyver <mark@taqtiqa.com>
@taqtiqa-mark taqtiqa-mark mentioned this issue Mar 21, 2022
Closed
@andylokandy
Copy link
Collaborator

I think the great job has been done by @taqtiqa-mark ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
Initial Publish
Development

No branches or pull requests
3 participants
@breezewish @andylokandy @zhongzc