Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command line arguments should support --version #386

Closed
andelf opened this issue Nov 10, 2016 · 1 comment · Fixed by #404 or #468
Closed

command line arguments should support --version #386

andelf opened this issue Nov 10, 2016 · 1 comment · Fixed by #404 or #468
Assignees
@overvenus

Comments

@andelf
Copy link
Contributor

andelf commented Nov 10, 2016

For now, pd only supports -v for printing version.

Among linux command line tools, -v often means verbose, -V/--version is used for version.
@andelf andelf changed the title command line arguments should support --version command line arguments should support --version Nov 10, 2016
overvenus added a commit to overvenus/pd that referenced this issue Nov 30, 2016
@overvenus
server/config.go: replace "v" with "version"
111452e 
close tikv#386
@overvenus overvenus mentioned this issue Nov 30, 2016
Merged
overvenus added a commit that referenced this issue Nov 30, 2016
@overvenus
server/config.go: replace "v" with "version" (#404)
6885ac5 
close #386
@andelf andelf reopened this Jan 7, 2017
@andelf
Copy link
Contributor Author

andelf commented Jan 7, 2017

in consistent with tidb/tikv, pd should support both -v and --version for a version tag.

overvenus added a commit to overvenus/pd that referenced this issue Jan 7, 2017
@overvenus
server/config.go: add flag v for version info
64521aa 
close tikv#386
@overvenus overvenus mentioned this issue Jan 7, 2017
Merged
overvenus added a commit that referenced this issue Jan 9, 2017
@overvenus
server/config.go: add flag v for version info (#468)
fdf9d9a 
close #386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@overvenus overvenus

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andelf @overvenus