Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make pd-server DASHBOARD=COMPILE should work #7593

Closed
HuSharp opened this issue Dec 20, 2023 · 0 comments · Fixed by #7594
Closed

make pd-server DASHBOARD=COMPILE should work #7593

HuSharp opened this issue Dec 20, 2023 · 0 comments · Fixed by #7594
Assignees
@HuSharp
Labels
type/enhancement The issue belongs to an enhancement.

Comments

@HuSharp
Copy link
Member

HuSharp commented Dec 20, 2023 •
edited

Enhancement Task

we can make pd-server DASHBOARD=COMPILE when want to build a custom dashboard

but now will meet some problems

Lockfile is up to date, resolution step is skipped
Already up to date
. prepare$ cd .. && husky install ui/.husky
│ husky - .git can't be found (see https://typicode.github.io/husky/#/?id=custom-directory)
└─ Failed in 107ms at /data/nvme0n1/husharp/proj/pd/.dashboard_build_temp/ui
 ELIFECYCLE  Command failed with exit code 1.
make: *** [Makefile:106: ui_deps] Error 1

This is because there is a tool which named husky in dashboard repo to lint commit messages

When we download dashboard and unzip to execute make ui will meet error .git can't be found.

To fix it, we can git init in tmp dashboard dir before we execute this command

because the tmp dashboard is a temporary dir, I don't think it'll be a problem.
@HuSharp HuSharp added the type/enhancement The issue belongs to an enhancement. label Dec 20, 2023
@HuSharp HuSharp self-assigned this Dec 20, 2023
@HuSharp HuSharp mentioned this issue Dec 20, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Dec 20, 2023
@HuSharp @ti-chi-bot
dashboard-ui: make custom dashboard ui work (#7594)
ebd2fc0 
close #7593

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HuSharp HuSharp

Labels
type/enhancement The issue belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dashboard-ui: make custom dashboard ui work HuSharp/pd
1 participant
@HuSharp