Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard-ui: make custom dashboard ui work #7594

Merged
merged 4 commits into from Dec 20, 2023

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Dec 20, 2023

What problem does this PR solve?

Issue Number: Close #7593

What is changed and how does it work?

we can make pd-server DASHBOARD=COMPILE when want to build a custom dashboard

but now will meet some problems

Lockfile is up to date, resolution step is skipped
Already up to date
. prepare$ cd .. && husky install ui/.husky
│ husky - .git can't be found (see https://typicode.github.io/husky/#/?id=custom-directory)
└─ Failed in 107ms at /data/nvme0n1/husharp/proj/pd/.dashboard_build_temp/ui
 ELIFECYCLE  Command failed with exit code 1.
make: *** [Makefile:106: ui_deps] Error 1

This is because there is a tool which named husky in dashboard repo to lint commit messages

When we download dashboard and unzip to execute make ui will meet error .git can't be found.

To fix it, we can git init in tmp dashboard dir before we execute this command

because the tmp dashboard is a temporary dir, I don't think it'll be a problem.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2023
@HuSharp HuSharp requested review from JmPotato, nolouch and CabinfeverB and removed request for HunDunDM December 20, 2023 07:30
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Merging #7594 (b60ba2e) into master (3b2e611) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head b60ba2e differs from pull request most recent head d64eb18. Consider uploading reports for the commit d64eb18 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7594   +/-   ##
=======================================
  Coverage   74.80%   74.80%           
=======================================
  Files         457      457           
  Lines       50392    50392           
=======================================
+ Hits        37694    37696    +2     
- Misses       9370     9371    +1     
+ Partials     3328     3325    -3     
Flag Coverage Δ
unittests 74.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2023
@CabinfeverB
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

This pull request has been accepted and is ready to merge.

Commit hash: b60ba2e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit ebd2fc0 into tikv:master Dec 20, 2023
22 checks passed
@HuSharp HuSharp deleted the make_dashboard_work branch December 20, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make pd-server DASHBOARD=COMPILE should work
4 participants