New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard-ui: make custom dashboard ui work #7594
Conversation
Signed-off-by: husharp <jinhao.hu@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7594 +/- ##
=======================================
Coverage 74.80% 74.80%
=======================================
Files 457 457
Lines 50392 50392
=======================================
+ Hits 37694 37696 +2
- Misses 9370 9371 +1
+ Partials 3328 3325 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: b60ba2e
|
@HuSharp: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Close #7593
What is changed and how does it work?
we can
make pd-server DASHBOARD=COMPILE
when want to build a custom dashboardbut now will meet some problems
This is because there is a tool which named husky in dashboard repo to lint commit messages
When we download dashboard and unzip to execute
make ui
will meet error.git can't be found
.To fix it, we can
git init
in tmp dashboard dir before we execute this commandbecause the tmp dashboard is a temporary dir, I don't think it'll be a problem.
Check List
Tests
Release note