Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd-ctl cannot remove a scheduler contains special characters #7798

Closed
JmPotato opened this issue Feb 4, 2024 · 0 comments · Fixed by #7799
Closed

pd-ctl cannot remove a scheduler contains special characters #7798

JmPotato opened this issue Feb 4, 2024 · 0 comments · Fixed by #7799
Labels
severity/moderate The issue's severity is moderate. type/bug The issue is confirmed as a bug.

Comments

@JmPotato
Copy link
Member

JmPotato commented Feb 4, 2024

Bug Report

What did you do?

./bin/pd-ctl -i
» scheduler show
[
  "evict-slow-store-scheduler",
  "balance-region-scheduler",
  "balance-leader-scheduler",
  "balance-hot-region-scheduler"
]

» scheduler add scatter-range --format=raw a b test
Success! The scheduler is created."

» scheduler show
[
  "balance-region-scheduler",
  "balance-leader-scheduler",
  "balance-hot-region-scheduler",
  "evict-slow-store-scheduler",
  "scatter-range-test"
]

» scheduler remove scatter-range-test
Success!
» scheduler show
[
  "balance-region-scheduler",
  "balance-leader-scheduler",
  "balance-hot-region-scheduler",
  "evict-slow-store-scheduler"
]

» scheduler add scatter-range --format=raw a b test#
Success! The scheduler is created."

» scheduler show
[
  "balance-hot-region-scheduler",
  "evict-slow-store-scheduler",
  "scatter-range-test#",
  "balance-region-scheduler",
  "balance-leader-scheduler"
]

» scheduler remove scatter-range-test#
[404] "[PD:scheduler:ErrSchedulerNotFound]scheduler not found"

» scheduler remove "scatter-range-test#"
[404] "[PD:scheduler:ErrSchedulerNotFound]scheduler not found"

» scheduler remove scatter-range-test\#
[404] "[PD:scheduler:ErrSchedulerNotFound]scheduler not found"

» scheduler show
[
  "evict-slow-store-scheduler",
  "scatter-range-test#",
  "balance-region-scheduler",
  "balance-leader-scheduler",
  "balance-hot-region-scheduler"
]

What did you expect to see?

The scheduler scatter-range-test# can be removed successfully.

What did you see instead?

[404] "[PD:scheduler:ErrSchedulerNotFound]scheduler not found"

What version of PD are you using (pd-server -V)?

master

@JmPotato JmPotato added the type/bug The issue is confirmed as a bug. label Feb 4, 2024
@github-actions github-actions bot added this to Need Triage in Questions and Bug Reports Feb 4, 2024
@JmPotato JmPotato added the severity/moderate The issue's severity is moderate. label Feb 4, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in #7799 Feb 4, 2024
ti-chi-bot bot pushed a commit that referenced this issue Feb 4, 2024
close #7798

Escape the scheduler name for some commands.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Questions and Bug Reports automation moved this from Need Triage to Closed Feb 4, 2024
ti-chi-bot bot pushed a commit that referenced this issue Feb 4, 2024
ref #7798

Remove the unexpected file commit made by #7799.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate The issue's severity is moderate. type/bug The issue is confirmed as a bug.
Projects
Development

Successfully merging a pull request may close this issue.

1 participant