Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd-ctl: escape the scheduler name for some commands #7799

Merged
merged 2 commits into from Feb 4, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Feb 4, 2024

What problem does this PR solve?

Issue Number: Close #7798.

What is changed and how does it work?

Escape the scheduler name for some commands.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
./bin/pd-ctl -i
» scheduler show
[
  "balance-hot-region-scheduler",
  "evict-slow-store-scheduler",
  "scatter-range-test#",
  "balance-region-scheduler",
  "balance-leader-scheduler"
]

» scheduler remove scatter-range-test#
Success!
» scheduler show
[
  "balance-region-scheduler",
  "balance-leader-scheduler",
  "balance-hot-region-scheduler",
  "evict-slow-store-scheduler"
]

Release note

Fix the bug that prevents pd-ctl from removing schedulers with special characters.

Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note The PR should write the release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Feb 4, 2024

/check-issue-triage-complete

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Merging #7799 (e523394) into master (54ffd34) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7799      +/-   ##
==========================================
- Coverage   73.45%   73.37%   -0.08%     
==========================================
  Files         432      432              
  Lines       47793    47793              
==========================================
- Hits        35104    35069      -35     
- Misses       9650     9672      +22     
- Partials     3039     3052      +13     
Flag Coverage Δ
unittests 73.37% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed status/LGT1 Indicates that a PR has LGTM 1. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

JmPotato commented Feb 4, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

This pull request has been accepted and is ready to merge.

Commit hash: e523394

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 21ced9a into tikv:master Feb 4, 2024
25 of 26 checks passed
@JmPotato JmPotato deleted the fix_scheduler_name_escape branch February 4, 2024 08:04
ti-chi-bot bot pushed a commit that referenced this pull request Feb 4, 2024
ref #7798

Remove the unexpected file commit made by #7799.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note The PR should write the release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pd-ctl cannot remove a scheduler contains special characters
3 participants