*: Do not use anonymous field in clusterInfo #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disksing
reviewed
May 28, 2018
server/cache.go
Outdated
| @@ -325,7 +325,7 @@ func (c *clusterInfo) GetRegionStores(region *core.RegionInfo) []*core.StoreInfo | |||
| func (c *clusterInfo) getRegionStores(region *core.RegionInfo) []*core.StoreInfo { | |||
| var stores []*core.StoreInfo | |||
| for id := range region.GetStoreIds() { | |||
| if store := c.Stores.GetStore(id); store != nil { | |||
| if store := c.core.Stores.GetStore(id); store != nil { | |||
There was a problem hiding this comment.
rename getRegionStores to getRegionStoresLocked?
server/cache.go
Outdated
| c.Stores.SetPendingPeerCount(id, c.Regions.GetStorePendingPeerCount(id)) | ||
| c.Stores.SetLeaderSize(id, c.Regions.GetStoreLeaderRegionSize(id)) | ||
| c.Stores.SetRegionSize(id, c.Regions.GetStoreRegionSize(id)) | ||
| c.core.Stores.SetLeaderCount(id, c.core.Regions.GetStoreLeaderCount(id)) |
There was a problem hiding this comment.
rename updateStoreStatus to updateStoreStatusLocked?
server/cache.go
Outdated
|
|
||
| // RegionReadStats returns hot region's read stats. | ||
| func (c *clusterInfo) RegionReadStats() []*core.RegionStat { | ||
| return c.core.HotCache.RegionStats(schedule.ReadFlow) |
server/cache.go
Outdated
|
|
||
| // RegionWriteStats returns hot region's write stats. | ||
| func (c *clusterInfo) RegionWriteStats() []*core.RegionStat { | ||
| return c.core.HotCache.RegionStats(schedule.WriteFlow) |
ti-chi-bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tools/pd-tso-bench (#5990) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref prometheus/client_golang#987, ref #987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tests/client (#5992) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot
added a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tests/mcs (#5993) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /client (#5991) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to forget to use Lock and then visit the anonymous field. This is not very safe.